-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bind-boot: look for ESPs on the same disk(s) as bootfs #700
Conversation
I tested this + coreos/fedora-coreos-config#1316 with:
Sadly I already closed that tmux pane, but I can assure you all three tests passed. :) |
Right now, to find the ESP devices, we just query all the devices on the system with the matching partition type. This is clumsy though. E.g. in case multipathing is in use, this will match both the multipathed version and the non-multipathed versions. Another case is multiple re-installs of the OS on different disks: we're working to ensure that users don't have multiple boot filesystems, but haven't so far required them to also wipe old ESPs. So we want to ensure we only modify the ESPs on *our* boot disk. Rework things by trying to be smarter: since we know what the right boot filesystem is (`coreos-boot-edit.service` uses `--boot-mount`), use that knowledge to derive the ESPs by only looking for them in the same storage hierarchy.
At present, that only proves that we found a parent device for |
I've manually checked it, though will look at adding it to |
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the boot mirroring tests. Specifically, it adds coverage for ESP devices discovery in a RAID1 setup (coreos/coreos-installer#700).
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the multipath tests. Specifically, it adds coverage for correct handling of the multipathed ESP partition (coreos/coreos-installer#700).
|
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the boot mirroring tests. Specifically, it adds coverage for ESP devices discovery in a RAID1 setup (coreos/coreos-installer#700).
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the multipath tests. Specifically, it adds coverage for correct handling of the multipathed ESP partition (coreos/coreos-installer#700).
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the boot mirroring tests. Specifically, it adds coverage for ESP devices discovery in a RAID1 setup (coreos/coreos-installer#700).
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the multipath tests. Specifically, it adds coverage for correct handling of the multipathed ESP partition (coreos/coreos-installer#700).
Right now, to find the ESP devices, we just query all the devices on the
system with the matching partition type. This is clumsy though. E.g. in
case multipathing is in use, this will match both the multipathed
version and the non-multipathed versions.
Another case is multiple re-installs of the OS on different disks: we're
working to ensure that users don't have multiple boot filesystems, but
haven't so far required them to also wipe old ESPs. So we want to ensure
we only modify the ESPs on our boot disk.
Rework things by trying to be smarter: since we know what the right boot
filesystem is (
coreos-boot-edit.service
uses--boot-mount
), use thatknowledge to derive the ESPs by only looking for them in the same
storage hierarchy.