bind-boot: look for ESPs on the same disk(s) as bootfs #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this + coreos/fedora-coreos-config#1316 with: Sadly I already closed that tmux pane, but I can assure you all three tests passed. :) |
Right now, to find the ESP devices, we just query all the devices on the system with the matching partition type. This is clumsy though. E.g. in case multipathing is in use, this will match both the multipathed version and the non-multipathed versions. Another case is multiple re-installs of the OS on different disks: we're working to ensure that users don't have multiple boot filesystems, but haven't so far required them to also wipe old ESPs. So we want to ensure we only modify the ESPs on *our* boot disk. Rework things by trying to be smarter: since we know what the right boot filesystem is (`coreos-boot-edit.service` uses `--boot-mount`), use that knowledge to derive the ESPs by only looking for them in the same storage hierarchy.
At present, that only proves that we found a parent device for |
I've manually checked it, though will look at adding it to |
bgilbert
approved these changes
Dec 2, 2021
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Dec 2, 2021
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the boot mirroring tests. Specifically, it adds coverage for ESP devices discovery in a RAID1 setup (coreos/coreos-installer#700).
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Dec 2, 2021
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the multipath tests. Specifically, it adds coverage for correct handling of the multipathed ESP partition (coreos/coreos-installer#700).
|
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Mar 22, 2022
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the boot mirroring tests. Specifically, it adds coverage for ESP devices discovery in a RAID1 setup (coreos/coreos-installer#700).
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Mar 22, 2022
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the multipath tests. Specifically, it adds coverage for correct handling of the multipathed ESP partition (coreos/coreos-installer#700).
jlebon
added a commit
to coreos/coreos-assembler
that referenced
this pull request
Mar 25, 2022
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the boot mirroring tests. Specifically, it adds coverage for ESP devices discovery in a RAID1 setup (coreos/coreos-installer#700).
jlebon
added a commit
to coreos/coreos-assembler
that referenced
this pull request
Mar 25, 2022
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the multipath tests. Specifically, it adds coverage for correct handling of the multipathed ESP partition (coreos/coreos-installer#700).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, to find the ESP devices, we just query all the devices on the
system with the matching partition type. This is clumsy though. E.g. in
case multipathing is in use, this will match both the multipathed
version and the non-multipathed versions.
Another case is multiple re-installs of the OS on different disks: we're
working to ensure that users don't have multiple boot filesystems, but
haven't so far required them to also wipe old ESPs. So we want to ensure
we only modify the ESPs on our boot disk.
Rework things by trying to be smarter: since we know what the right boot
filesystem is (
coreos-boot-edit.serviceuses--boot-mount), use thatknowledge to derive the ESPs by only looking for them in the same
storage hierarchy.